Make calendar schedule options translatable #29375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Oct 22, 2021
juliusknorr
commented
- Rename the guests input to "Number of guests" to be more descriptive
- Make placeholder of inputs translatable
juliusknorr
added
bug
3. to review
juliusknorr
requested review from
a team,
ChristophWurst,
GretaD,
Pytal,
artonge and
szaimen
and removed request for
a team
szaimen
requested changes
Oct 22, 2021
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/translate-calendar-schedule-response
branch
from
cee471e to
b30f499
Compare
ChristophWurst
approved these changes
Oct 22, 2021
szaimen
approved these changes
Oct 22, 2021
szaimen
added
4. to release
nickvergessen
approved these changes
Oct 22, 2021
Contributor
|
Failing test is unrelated |
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
This was referenced Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.