Skip to content

Support PHP 8.1 - First batch #29432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 17 commits into from
Nov 23, 2021
Merged

Support PHP 8.1 - First batch #29432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
113756d
Fix ArrayAccess and JsonSerializable return types
come-nc Oct 19, 2021
af7bf98
Fix Iterator return types
come-nc Oct 21, 2021
66bdda5
Fix Guzzle function calls
come-nc Oct 21, 2021
bc3acfc
Fix test class names
come-nc Oct 21, 2021
3a1b374
Fix DateTime constructor calls with null
come-nc Oct 21, 2021
008b79d
Fix type errors
come-nc Oct 21, 2021
bb9c099
Fix FolderTest calls to Mountpoint constructor with wrong type
come-nc Oct 25, 2021
0655315
Fix Encryption tests on PHP 8.1
come-nc Oct 25, 2021
9d170f1
Fix warning about passing null to rtrim
come-nc Oct 25, 2021
ee7ef77
Fix warning about passing null to substr_count
come-nc Oct 25, 2021
25fa0b8
Fix TempManager test errors about passing null to is_dir
come-nc Oct 25, 2021
cd72045
Make mock config return default value to fix warnings
come-nc Oct 25, 2021
8b271b8
Fix tests and avoid PHP errors in them
come-nc Oct 25, 2021
5a20e20
Fix errors in AvatarController when data() returns null
come-nc Oct 25, 2021
5cd5245
Fix dav application tests and code for PHP 8.1
come-nc Oct 25, 2021
10dfded
Fix errors from files applications tests on PHP 8.1
come-nc Oct 25, 2021
18a91f0
Fix default value for $type in OC\DB\QueryBuilder\ExpressionBuilder\E…
come-nc Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix DateTime constructor calls with null 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Nov 23, 2021
commit 3a1b3745eb8e43eaa830bdeb9fe53a2de70349f0
2 changes: 1 addition & 1 deletion lib/private/Log/LogDetails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function logDetails(string $app, $message, int $level): array {
}
$time = \DateTime::createFromFormat("U.u", number_format(microtime(true), 4, ".", ""));
if ($time === false) {
$time = new \DateTime(null, $timezone);
$time = new \DateTime('now', $timezone);
} else {
// apply timezone if $time is created from UNIX timestamp
$time->setTimezone($timezone);
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/AppFramework/Http/DispatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ protected function setUp(): void {

$this->response = $this->createMock(Response::class);

$this->lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$this->lastModified = new \DateTime('now', new \DateTimeZone('GMT'));
$this->etag = 'hi';
}

Expand Down
6 changes: 3 additions & 3 deletions tests/lib/AppFramework/Http/ResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public function testGetEtag() {


public function testGetLastModified() {
$lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$lastModified = new \DateTime('now', new \DateTimeZone('GMT'));
$lastModified->setTimestamp(1);
$this->childResponse->setLastModified($lastModified);
$this->assertEquals($lastModified, $this->childResponse->getLastModified());
Expand Down Expand Up @@ -252,15 +252,15 @@ public function testCacheSeconds() {


public function testEtagLastModifiedHeaders() {
$lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$lastModified = new \DateTime('now', new \DateTimeZone('GMT'));
$lastModified->setTimestamp(1);
$this->childResponse->setLastModified($lastModified);
$headers = $this->childResponse->getHeaders();
$this->assertEquals('Thu, 01 Jan 1970 00:00:01 +0000', $headers['Last-Modified']);
}

public function testChainability() {
$lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$lastModified = new \DateTime('now', new \DateTimeZone('GMT'));
$lastModified->setTimestamp(1);

$this->childResponse->setEtag('hi')
Expand Down