Skip to content

Revamp profile visibility section #29482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 4 commits into from
Nov 4, 2021
Merged

Revamp profile visibility section #29482

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee1c6ee
Add additional check on action registrations
Pytal Oct 28, 2021
eb6217f
Better function descriptions
Pytal Oct 28, 2021
50a6612
Refine profile backend for frontend visibility requirements
Pytal Oct 28, 2021
19c62d0
Add new profile visibility section
Pytal Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better function descriptions 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Nov 3, 2021
commit eb6217f551da044110f56c1ff69e58bad2cbdcb0
6 changes: 4 additions & 2 deletions lib/private/Profile/ProfileManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ private function getActions(IUser $targetUser, ?IUser $visitingUser): array {
}

/**
* Return whether the profile parameter is visible to the visiting user
* Return whether the profile parameter of the target user
* is visible to the visiting user
*/
private function isParameterVisible(IUser $targetUser, ?IUser $visitingUser, string $paramId): bool {
try {
Expand Down Expand Up @@ -247,7 +248,8 @@ private function isParameterVisible(IUser $targetUser, ?IUser $visitingUser, str
}

/**
* Return the profile parameters
* Return the profile parameters of the target user that are visible to the visiting user
* in an associative array
*/
public function getProfileParams(IUser $targetUser, ?IUser $visitingUser): array {
$account = $this->accountManager->getAccount($targetUser);
Expand Down