Skip to content

Support LDAP dns longer than 255 characters #29523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 10 commits into from
Dec 9, 2021
Merged

Support LDAP dns longer than 255 characters #29523

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
662e324
Support LDAP dns longer than 255 characters
come-nc Nov 2, 2021
31a503b
Change column names to ldap_dn and ldap_dn_hash and add migration
come-nc Nov 4, 2021
9a1df9d
Fix variable names
nickvergessen Nov 4, 2021
ce5192a
Fixed migration step for user_ldap
come-nc Nov 4, 2021
d4c49a3
Put back length check to have a clear error
come-nc Nov 4, 2021
c4d8bd9
Fixes in migration step
come-nc Nov 4, 2021
14f0020
Add the columns and alter the index in Version1010Date20200630192842
come-nc Nov 18, 2021
df25a6d
Make sure that hash function returns a string
come-nc Nov 18, 2021
5143249
Add an index for directory_uuid as well
come-nc Nov 18, 2021
a359047
Use clearer names for variables
come-nc Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix variable names 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @come-nc
nickvergessen authored and come-nc committed Nov 23, 2021
commit 9a1df9ddca45a2d20bc748b18a986166e2fa809c
4 changes: 2 additions & 2 deletions apps/user_ldap/lib/Migration/Version1130Date20211102154716.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
$column->setLength(4096);
$changeSchema = true;
}
if ($table === 'ldap_user_mapping') {
if ($tableName === 'ldap_user_mapping') {
if ($table->hasIndex('ldap_dn_users')) {
$table->dropIndex('ldap_dn_users');
$changeSchema = true;
Expand Down Expand Up @@ -132,7 +132,7 @@ protected function getSelectQuery(string $table): IQueryBuilder {
protected function getUpdateQuery(string $table): IQueryBuilder {
$q = $this->dbc->getQueryBuilder();
$q->update($table)
->set('ldap_dn_hash', $query->createParameter('dn_hash'))
->set('ldap_dn_hash', $q->createParameter('dn_hash'))
->where($q->expr()->eq('owncloud_name', $q->createParameter('name')));
return $q;
}
Expand Down