Skip to content

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

Signed-off-by: Joas Schilling <[email protected]>
@danxuliu danxuliu added 3. to review Waiting for reviews bug labels Nov 12, 2021
@danxuliu danxuliu added this to the Nextcloud 23 milestone Nov 12, 2021
@szaimen
Copy link
Contributor

szaimen commented Nov 12, 2021

@skjnldsv stable23 is not protected?

@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 12, 2021
@nickvergessen
Copy link
Member Author

skjnldsv stable23 is not protected?

It was, what makes you think it would be not?

@nickvergessen nickvergessen merged commit 35546c0 into stable23 Nov 12, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/fix-video-verification-tests branch November 12, 2021 11:19
@szaimen
Copy link
Contributor

szaimen commented Nov 12, 2021

It was, what makes you think it would be not?

Looked like merging was green although only 1 person did approve. and it didn't show that 2 people are required to approve...

@nickvergessen
Copy link
Member Author

Right, bumped the approval count to 2

@blizzz blizzz mentioned this pull request Nov 12, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants