Skip to content

Set 'app_password' in session only when using a permanent token #29729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julien-nc wants to merge 3 commits into from
Closed

Set 'app_password' in session only when using a permanent token #29729

julien-nc wants to merge 3 commits into from

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Nov 16, 2021

Like mentioned there nextcloud/globalsiteselector#51 (comment)
Maybe we should check the token type to decide if app_password should be set in the session.

getType() is now declared in IToken and implemented by PublicKeyToken and DefaultToken.

@julien-nc julien-nc added this to the Nextcloud 24 milestone Nov 16, 2021
@julien-nc julien-nc mentioned this pull request Nov 16, 2021
Merged
ChristophWurst
ChristophWurst reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also test this a bit but from a code perspective this seems right 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 30, 2021
@ChristophWurst ChristophWurst force-pushed the enh/app-password-set-condition branch from d5eee7d to 853bcff Compare December 30, 2021 14:49
@blizzz
Copy link
Member

blizzz commented Jan 12, 2022

CI's happiness would love to get to new heights

@julien-nc julien-nc force-pushed the enh/app-password-set-condition branch from 4b485a1 to a09d54c Compare March 8, 2022 16:03
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Apr 7, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/app-password-set-condition branch from a09d54c to 7e07485 Compare April 7, 2022 13:50
@PVince81 PVince81 requested a review from nickvergessen April 8, 2022 15:53
@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@blizzz
Copy link
Member

blizzz commented Jun 21, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/app-password-set-condition branch from 7e07485 to 03a2f77 Compare June 21, 2022 16:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 21, 2022
View reviewed changes
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Feb 27, 2024

Could your rebase and fix conflicts @julien-nc 🙈 🙇

@skjnldsv skjnldsv added the stale Ticket or PR with no recent activity label Feb 27, 2024
@skjnldsv skjnldsv marked this pull request as draft February 27, 2024 17:51
This was referenced Mar 12, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv
Copy link
Member

skjnldsv commented May 2, 2024

Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. ☺️
Our aim is to keep the project moving forward with active collaboration. Thank you for your understanding and continued support! 🙏

@skjnldsv skjnldsv closed this May 2, 2024
@skjnldsv skjnldsv deleted the enh/app-password-set-condition branch May 2, 2024 14:35
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

2. developing Work in progress enhancement feature: authentication stale Ticket or PR with no recent activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@julien-nc @blizzz @skjnldsv @ChristophWurst @juliusknorr