Skip to content

Conversation

@rakekniven
Copy link
Member

Reported at Transifex.

Signed-off-by: rakekniven [email protected]

Reported at Transifex.

Signed-off-by: rakekniven <[email protected]>
@rakekniven rakekniven added the feature: language/translations (l10n/i18n) Localization and translation matters label Nov 17, 2021
@rakekniven rakekniven self-assigned this Nov 17, 2021
@szaimen szaimen added this to the Nextcloud 24 milestone Nov 17, 2021
@PVince81 PVince81 merged commit c833a4b into master Nov 17, 2021
@PVince81 PVince81 deleted the rakekniven-patch-2 branch November 17, 2021 11:02
@MichaIng
Copy link
Member

/backport to stable23

@rakekniven
Copy link
Member Author

Most times it was backported to the last three supported major versions.
This time only upcoming v23. What is the reason for?

@MichaIng
Copy link
Member

No specific reason, I just didn't check yet whether the same string is present on older versions.

@rakekniven
Copy link
Member Author

Understood.

@MichaIng
Copy link
Member

/backport to stable22

@MichaIng
Copy link
Member

MichaIng commented Nov 17, 2021

Interestingly on NC21 this was correct: https://github.com/nextcloud/server/blob/stable21/apps/files_external/templates/settings.php#L210

Ah here is the commit: 35d978c
I guess search&replace / sed -i used while in this one case it was part of a sentence and hence broke grammar 😄.

Going through the changed cases there are actually other cases where it is at least questionable whether singular is better or even correct 🤔.

used to distinguish things like shares and external storage

Return the mountpoint name of external storage that are not mounted as user home

restricted, or if external storage which do not support streaming are in

Here definitely wrong!

etc etc.

If someone has time, would be good to go through all of them and revert where necessary.

@rakekniven
Copy link
Member Author

Good catch

@rakekniven
Copy link
Member Author

rakekniven commented Nov 17, 2021

@szaimen Please be careful next time you do some sed action like this ;-) Thanks.

The translators are after you 👻

@szaimen
Copy link
Contributor

szaimen commented Nov 17, 2021

I was careful but didn't see this one place where it was correct ;)

@MichaIng
Copy link
Member

As mentioned above, there are some some cases. But most are code comments, hence harmless/not visible to users 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants