-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fixed grammar #29734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed grammar #29734
Conversation
Reported at Transifex. Signed-off-by: rakekniven <[email protected]>
|
/backport to stable23 |
|
Most times it was backported to the last three supported major versions. |
|
No specific reason, I just didn't check yet whether the same string is present on older versions. |
|
Understood. |
|
/backport to stable22 |
|
Interestingly on NC21 this was correct: https://github.com/nextcloud/server/blob/stable21/apps/files_external/templates/settings.php#L210 Ah here is the commit: 35d978c Going through the changed cases there are actually other cases where it is at least questionable whether singular is better or even correct 🤔.
Here definitely wrong! etc etc. If someone has time, would be good to go through all of them and revert where necessary. |
|
Good catch |
|
@szaimen Please be careful next time you do some The translators are after you 👻 |
|
I was careful but didn't see this one place where it was correct ;) |
|
As mentioned above, there are some some cases. But most are code comments, hence harmless/not visible to users 😉. |
Reported at Transifex.
Signed-off-by: rakekniven [email protected]