Skip to content

[stable22] Fix missing setlocale with php 8 #29743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaIng merged 6 commits into from
Nov 17, 2021
Merged

[stable22] Fix missing setlocale with php 8 #29743

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5cff00
Fix missing setlocale with php 8
YoitoFes Nov 13, 2021
87a5620
Check whether setlocale works only after setlocale
YoitoFes Nov 13, 2021
0c1f108
Add check whether escapeshellcmd behaves the same as basename
YoitoFes Nov 15, 2021
0bb3232
OC_Util: Add fallbacks to check if current locale is UTF8
YoitoFes Nov 15, 2021
a0cd7fc
OC_Util::isSetLocaleWorking: fix typo
YoitoFes Nov 15, 2021
4d1daa5
OC_Util::isNonUTF8Locale: fix lint error
YoitoFes Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix missing setlocale with php 8 
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <[email protected]>
  • Loading branch information
@YoitoFes @backportbot
YoitoFes authored and backportbot[bot] committed Nov 17, 2021
commit d5cff00d1042c557e034ae9c80aac1b2f35076d9
4 changes: 2 additions & 2 deletions lib/private/legacy/OC_Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,14 +1280,14 @@ public function isHtaccessWorking(\OCP\IConfig $config) {
* @return bool
*/
public static function isSetLocaleWorking() {
if ('' === basename('§')) {
if ('' === escapeshellcmd('§')) {
// Borrowed from \Patchwork\Utf8\Bootup::initLocale
setlocale(LC_ALL, 'C.UTF-8', 'C');
setlocale(LC_CTYPE, 'en_US.UTF-8', 'fr_FR.UTF-8', 'es_ES.UTF-8', 'de_DE.UTF-8', 'ru_RU.UTF-8', 'pt_BR.UTF-8', 'it_IT.UTF-8', 'ja_JP.UTF-8', 'zh_CN.UTF-8', '0');
}

// Check again
if ('' === basename('§')) {
if ('' === escapeshellcmd('§')) {
return false;
}
return true;
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/UtilTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ public function testEncodePath() {
$this->assertEquals("/%C2%A7%23%40test%25%26%5E%C3%A4/-child", $result);
}

public function testIsSetLocaleWorking() {
// OC_Util::isSetLocaleWorking() assumes escapeshellcmd('§') returns '' with non-UTF-8 locale.
$locale = setlocale(LC_CTYPE, 0);
setlocale(LC_CTYPE, 'C');
$this->assertEquals('', escapeshellcmd('§'));
setlocale(LC_CTYPE, $locale);
}

public function testFileInfoLoaded() {
$expected = function_exists('finfo_open');
$this->assertEquals($expected, \OC_Util::fileInfoLoaded());
Expand Down