-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Replace CalDAV availability component with component lib #29796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CalDAV availability component with component lib #29796
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a34539d to
b119295
Compare
b119295 to
1e4926e
Compare
1e4926e to
51c457d
Compare
miaulalala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't save working hours any more:
could not save availability TypeError: Object(...) is not a function
at _callee2$ (CalendarService.js:134)
at tryCatch (runtime.js:63)
at Generator.invoke [as _invoke] (runtime.js:294)
at Generator.next (runtime.js:119)
at asyncGeneratorStep (CalendarService.js:19)
at _next (CalendarService.js:21)
at CalendarService.js:21
at new Promise (<anonymous>)
at CalendarService.js:21
at _saveScheduleInboxAvailability (CalendarService.js:152)```
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
|
Works now! |
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
51c457d to
5dcc47e
Compare
|
Drone failure unrelated. |
5dcc47e to
d2666b5
Compare
|
/compile amend / |
d2666b5 to
2e9af65
Compare
doesn't work anymore, yay. |
Done! Tested and it works fine again. |
|
I tried to rebase and have bad news: server requires @nextcloud/vue v5 but calendar-availability-vue requires v4.2 as a peer. We have to update and release the lib first. |
Signed-off-by: Christoph Wurst <[email protected]>
20dfee7 to
daf1b5f
Compare
Requires nextcloud/calendar-availability-vue#6
/settings/user/groupwareshould work like before. This is an internal clean-up/refactoring to deduplicate some code.This also fixes the regression from #30020 that all of the personal settings front-end was missing.