Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 19, 2021

Requires nextcloud/calendar-availability-vue#6

/settings/user/groupware should work like before. This is an internal clean-up/refactoring to deduplicate some code.

This also fixes the regression from #30020 that all of the personal settings front-end was missing.

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Nov 19, 2021
@ChristophWurst

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from a34539d to b119295 Compare January 3, 2022 09:54
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement and removed 2. developing Work in progress labels Jan 3, 2022
@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Jan 3, 2022
@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from b119295 to 1e4926e Compare January 3, 2022 09:57
@ChristophWurst ChristophWurst marked this pull request as ready for review January 3, 2022 09:57
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 3, 2022
@ChristophWurst ChristophWurst marked this pull request as draft January 3, 2022 09:59
@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from 1e4926e to 51c457d Compare January 3, 2022 10:29
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 3, 2022
@ChristophWurst ChristophWurst self-assigned this Jan 3, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review January 3, 2022 10:29
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't save working hours any more:

could not save availability TypeError: Object(...) is not a function
    at _callee2$ (CalendarService.js:134)
    at tryCatch (runtime.js:63)
    at Generator.invoke [as _invoke] (runtime.js:294)
    at Generator.next (runtime.js:119)
    at asyncGeneratorStep (CalendarService.js:19)
    at _next (CalendarService.js:21)
    at CalendarService.js:21
    at new Promise (<anonymous>)
    at CalendarService.js:21
    at _saveScheduleInboxAvailability (CalendarService.js:152)```

@ChristophWurst

This comment was marked as off-topic.

@ChristophWurst

This comment was marked as off-topic.

@miaulalala

This comment was marked as off-topic.

@ChristophWurst

This comment was marked as off-topic.

@miaulalala

This comment was marked as off-topic.

@ChristophWurst

This comment was marked as off-topic.

@miaulalala

This comment has been minimized.

@miaulalala miaulalala self-requested a review January 3, 2022 14:24
@miaulalala
Copy link
Contributor

Works now!

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2022
@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from 51c457d to 5dcc47e Compare February 9, 2022 18:00
@miaulalala
Copy link
Contributor

Drone failure unrelated.

@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from 5dcc47e to d2666b5 Compare February 11, 2022 10:54
@ChristophWurst
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the refactor/calendar-availability-component branch from d2666b5 to 2e9af65 Compare February 11, 2022 11:09
@ChristophWurst
Copy link
Member Author

Uncaught ReferenceError: assignment to undeclared variable ICAL

doesn't work anymore, yay.

@ChristophWurst
Copy link
Member Author

@st3iny
Copy link
Member

st3iny commented Feb 15, 2022

@st3iny
Copy link
Member

st3iny commented Feb 15, 2022

I tried to rebase and have bad news: server requires @nextcloud/vue v5 but calendar-availability-vue requires v4.2 as a peer. We have to update and release the lib first.

@ChristophWurst ChristophWurst force-pushed the refactor/calendar-availability-component branch from 20dfee7 to daf1b5f Compare February 17, 2022 08:38
@ChristophWurst ChristophWurst merged commit 926bfd5 into master Feb 17, 2022
@ChristophWurst ChristophWurst deleted the refactor/calendar-availability-component branch February 17, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

Development

Successfully merging this pull request may close these issues.

4 participants