Skip to content

[stable22] Make sure mapping cache is cleared when deleting a user #29850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaIng merged 2 commits into from
Nov 25, 2021
Merged

[stable22] Make sure mapping cache is cleared when deleting a user #29850

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2764a
Make sure mapping cache is cleared when deleting a user
come-nc Nov 22, 2021
d895cd9
Test cache invalidation for AbstractMapping in test suite
come-nc Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make sure mapping cache is cleared when deleting a user 
This avoids phantom remnants staying after user deletion

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Nov 23, 2021
commit 5b2764a2aa6f5641dde5ce2843fec4d71a9ad332
5 changes: 5 additions & 0 deletions apps/user_ldap/lib/Mapping/AbstractMapping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,11 @@ public function unmap($name) {
DELETE FROM `' . $this->getTableName() . '`
WHERE `owncloud_name` = ?');

$dn = array_search($name, $this->cache);
if ($dn !== false) {
unset($this->cache[$dn]);
}

return $this->modify($statement, [$name]);
}

Expand Down