-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Prevent your own status from replacing another user's status on profile #29870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
/backport to stable23 |
8af1b4e to
5cfb0c7
Compare
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sens to have that directly in the handleStatusUpdate method ?
handleStatusUpdate(status) {
if (!this.isCurrentUser) {
return
}
this.status = status
},
Had considered that as well, but I think preventing the subscription higher up in |
Can't help thinking that in one way or another, the state during |
5cfb0c7 to
5be1595
Compare
This comment has been minimized.
This comment has been minimized.
Good point, changed it to add checks to the |
5be1595 to
a40a696
Compare
a40a696 to
a6b67fa
Compare
|
/compile amend / |
Signed-off-by: Christopher Ng <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
a6b67fa to
3aea0f2
Compare
See title 👆