Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Nov 23, 2021

See title 👆

@Pytal Pytal added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Nov 23, 2021
@Pytal Pytal added this to the Nextcloud 24 milestone Nov 23, 2021
@Pytal Pytal requested a review from a team November 23, 2021 23:55
@Pytal Pytal self-assigned this Nov 23, 2021
@Pytal Pytal requested review from PVince81, julien-nc and juliusknorr and removed request for a team November 23, 2021 23:55
@Pytal

This comment has been minimized.

@Pytal
Copy link
Member Author

Pytal commented Nov 23, 2021

/backport to stable23

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sens to have that directly in the handleStatusUpdate method ?

		handleStatusUpdate(status) {
			if (!this.isCurrentUser) {
				return
			}

			this.status = status
		},

@Pytal
Copy link
Member Author

Pytal commented Nov 25, 2021

Would it make more sens to have that directly in the handleStatusUpdate method ?

Had considered that as well, but I think preventing the subscription higher up in mounted() is better as otherwise we'd have an arbitrary event listener

@artonge
Copy link
Contributor

artonge commented Nov 25, 2021

Had considered that as well, but I think preventing the subscription higher up in mounted() is better as otherwise we'd have an arbitrary event listener

Can't help thinking that in one way or another, the state during mounted and during beforeDestroy could be different.

@Pytal Pytal force-pushed the fix/erroneous-status-on-profile branch from 5cfb0c7 to 5be1595 Compare November 26, 2021 02:19
@Pytal

This comment has been minimized.

@Pytal
Copy link
Member Author

Pytal commented Nov 26, 2021

Can't help thinking that in one way or another, the state during mounted and during beforeDestroy could be different.

Good point, changed it to add checks to the handleStatusUpdate method instead :)

@nextcloud-command nextcloud-command force-pushed the fix/erroneous-status-on-profile branch from 5be1595 to a40a696 Compare November 26, 2021 02:34
@Pytal Pytal force-pushed the fix/erroneous-status-on-profile branch from a40a696 to a6b67fa Compare November 29, 2021 18:55
@Pytal
Copy link
Member Author

Pytal commented Nov 29, 2021

/compile amend /

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/erroneous-status-on-profile branch from a6b67fa to 3aea0f2 Compare November 29, 2021 19:05
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 29, 2021
@Pytal Pytal merged commit 393ea92 into master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants