Skip to content

More explicit empty profile message #29892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pytal wants to merge 1 commit into from
Closed

More explicit empty profile message #29892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/settings/js/vue-settings-personal-info.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/settings/js/vue-settings-personal-info.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/settings/src/constants/AccountPropertyConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const ACCOUNT_PROPERTY_ENUM = Object.freeze({
export const ACCOUNT_PROPERTY_READABLE_ENUM = Object.freeze({
ADDRESS: t('settings', 'Address'),
AVATAR: t('settings', 'Avatar'),
BIOGRAPHY: t('settings', 'About'),
BIOGRAPHY: t('settings', 'Biography'),
DISPLAYNAME: t('settings', 'Full name'),
EMAIL_COLLECTION: t('settings', 'Additional email'),
EMAIL: t('settings', 'Email'),
Expand Down
4 changes: 2 additions & 2 deletions core/js/dist/profile.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/profile.js.map
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 10 additions & 4 deletions core/src/views/Profile.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@
title=""
fill-color="var(--color-text-maxcontrast)"
:size="60" />
<h3>{{ emptyProfileMessage }}</h3>
<p>{{ t('core', 'The headline and about sections will show up here') }}</p>
<h3>{{ emptyProfileHeading }}</h3>
<p>{{ emptyProfileMessage }}</p>
</div>
</template>
</div>
Expand Down Expand Up @@ -256,10 +256,16 @@ export default {
return getComputedStyle(document.body).getPropertyValue('--color-main-background').trim()
},

emptyProfileHeading() {
return this.isCurrentUser
? t('core', 'You haven\'t added a headline or biography yet')
: t('core', '{user} hasn\'t added a headline or biography yet', { user: (this.displayname || this.userId) })
},

emptyProfileMessage() {
return this.isCurrentUser
? t('core', 'You haven\'t added any info yet')
: t('core', '{user} hasn\'t added any info yet', { user: (this.displayname || this.userId) })
? t('core', 'Your added info will show up here')
: t('core', 'Added info of {user} will show up here', { user: (this.displayname || this.userId) })
},
},

Expand Down
2 changes: 1 addition & 1 deletion lib/private/Profile/ProfileManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ public function getProfileConfigWithMetadata(IUser $targetUser, ?IUser $visiting
],
IAccountManager::PROPERTY_BIOGRAPHY => [
'appId' => self::CORE_APP_ID,
'displayId' => $this->l10nFactory->get('lib')->t('About'),
'displayId' => $this->l10nFactory->get('lib')->t('Biography'),
],
IAccountManager::PROPERTY_DISPLAYNAME => [
'appId' => self::CORE_APP_ID,
Expand Down