Use strict comparison to detect usage of redis cluster #29906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
artonge
added
bug
feature: caching
Contributor
Author
|
/backport to stable22 |
Contributor
Author
|
/backport to stable23 |
CarlSchwan
approved these changes
Nov 25, 2021
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking the presence of the
redis.clusterproperty in the config, thein_arrayfunction can returntruewhen the config contains a0property as(int)'redis.cluster' === 0.Puting aside the reason behind the presence of a
0property, strict comparisons are always safer, and prevent weird bugs.Fixes: #28609
Doc: https://www.php.net/manual/en/function.in-array.php