Interpolate the log message also for logged exceptions #29951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to PSR-3 the log message can have placeholders that are replaced from the context object. Our logger implementation did that for all PSR-3 logger methods. The only exception was our custom `logException`. Since PsrLoggerAdapter calls logException when an exception key is present in the context object, log messages were no longer interpolated. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
a team,
danxuliu,
julien-nc and
nickvergessen
ChristophWurst
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
icewind1991
approved these changes
Nov 29, 2021
nickvergessen
approved these changes
Nov 29, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Fine by me also with backports, but 20 is EOL
Member
Author
TIL! |
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PSR-3 the log message can have placeholders that are
replaced from the context object. Our logger implementation did that for
all PSR-3 logger methods. The only exception was our custom
logException.Since PsrLoggerAdapter calls logException when an exception key is
present in the context object, log messages were no longer interpolated.
Tested with the following snippet
On master I get
oh {no}in my log. With this patch it'soh no.