Skip to content

Fix relation "user_id" already exists migration error #29996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 2 commits into from
Dec 9, 2021
Merged

Fix relation "user_id" already exists migration error #29996

Pytal merged 2 commits into from
Dec 9, 2021

Conversation

@zordsdavini
Copy link

@zordsdavini zordsdavini commented Dec 1, 2021 •
edited by Pytal
Loading

Ref: #29986

@solracsf solracsf linked an issue Dec 1, 2021 that may be closed by this pull request
upgrade to 23 (beta) failed #29986
Closed
PVince81
PVince81 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from Pytal and juliusknorr December 1, 2021 08:43
@szaimen szaimen added this to the Nextcloud 24 milestone Dec 1, 2021
Pytal
Pytal requested changes Dec 1, 2021
View reviewed changes
@Pytal
Copy link
Member

Pytal commented Dec 1, 2021

/backport to stable23

@Pytal Pytal added 3. to review Waiting for reviews bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Dec 1, 2021
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 2, 2021
@Pytal
Copy link
Member

Pytal commented Dec 2, 2021

Thanks for the fix @zordsdavini!

@Pytal
Copy link
Member

Pytal commented Dec 3, 2021

@skjnldsv @blizzz any idea on the drone failures?

@juliusknorr
Copy link
Member

juliusknorr commented Dec 3, 2021

Restarted drone

blizzz
blizzz previously requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a repair step to rename the index on existing setup

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Dec 3, 2021
@solracsf solracsf changed the title fix #29986 Fix for Duplicate table \"user_id\" already exists Dec 3, 2021
@Pytal
Copy link
Member

Pytal commented Dec 3, 2021

Fix now updates index name of original migration to fix new upgrades and adds a new migration for previously migrated setups to rename the existing index

@Pytal Pytal requested a review from blizzz December 3, 2021 20:05
@Pytal Pytal changed the title Fix for Duplicate table \"user_id\" already exists Fix relation "user_id" already exists migration error Dec 3, 2021
@Pytal Pytal self-assigned this Dec 3, 2021
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 3, 2021
skjnldsv
skjnldsv reviewed Dec 9, 2021
View reviewed changes
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 9, 2021
@Pytal @skjnldsv
Update core/Migrations/Version23000Date20211203110726.php
ac5bc22 
Co-authored-by: John Molakvoæ <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal merged commit 92d3520 into nextcloud:master Dec 9, 2021
@welcome
Copy link

welcome bot commented Dec 9, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2021
Merged
@Pytal Pytal mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

upgrade to 23 (beta) failed

8 participants

@zordsdavini @Pytal @juliusknorr @PVince81 @blizzz @skjnldsv @197788 @szaimen