Skip to content

Remove default token which is deprecated since Nextcloud 13 #30016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 7 commits into from
Dec 2, 2021
Merged

Remove default token which is deprecated since Nextcloud 13 #30016

nickvergessen merged 7 commits into from
Dec 2, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 1, 2021

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Dec 1, 2021
@nickvergessen nickvergessen requested review from a team, CarlSchwan, ChristophWurst, PVince81 and skjnldsv and removed request for a team December 1, 2021 17:43
@MichaIng

This comment has been minimized.

Sign in to view
@nickvergessen

This comment has been minimized.

Sign in to view
@MichaIng

This comment has been minimized.

Sign in to view
@CarlSchwan
Fix tests
a8866b0 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan

This comment has been minimized.

Sign in to view
@nickvergessen
More unit test adjustments
9f00179 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
More test fixing
c6ae530 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
More test fixing
3e20cff 
Signed-off-by: Joas Schilling <[email protected]>
@MichaIng

This comment has been minimized.

Sign in to view
@nickvergessen

This comment has been minimized.

Sign in to view
@MichaIng

This comment has been minimized.

Sign in to view
@nickvergessen
Fix last tests
6175283 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 2, 2021

Right, pushed

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 2, 2021
@MichaIng
Copy link
Member

MichaIng commented Dec 2, 2021

php-cs check:

Warning: Found violation(s) of type: class_definition
Warning: Found violation(s) of type: braces
Warning: Found violation(s) of type: no_unused_imports

Can it be configured to be a bit more verbose, at best print file and line where these violations have been found? I cannot find them 🤔.

@nickvergessen
Remove unused imports
6d33d75 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 2, 2021

Can it be configured to be a bit more verbose, at best print file and line where these violations have been found? I cannot find them 🤔

Everyone wished

@nickvergessen nickvergessen merged commit 7acb438 into master Dec 2, 2021
@nickvergessen nickvergessen deleted the techdebt/noid/remove-default-token-provider branch December 2, 2021 15:48
@nickvergessen nickvergessen mentioned this pull request Jan 31, 2022
Merged
@PrivatePuffin PrivatePuffin mentioned this pull request May 7, 2022
Closed
@tcitworld tcitworld mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@MichaIng MichaIng MichaIng approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: authentication technical debt

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @MichaIng @CarlSchwan @ChristophWurst