Skip to content

[stable23] Fix input for groups validation in new user form #30144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Dec 9, 2021
Merged

[stable23] Fix input for groups validation in new user form #30144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b53eb4
Fix input for groups validation in new user form
danxuliu Nov 29, 2021
30733d0
Remove no longer needed CSS rules
danxuliu Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove no longer needed CSS rules 
Since Nextcloud 22 the "#new-user" rules had no effect, as the DOM
structure changed to show a dialog rather than adding a row on top of
the list when adding new users.

Similarly, the z-index was no longer needed, as there will be no
"new-user" row that could overlap. Moreover, the z-index was set even
higher (100) in another rule still active.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Dec 9, 2021
commit 30733d020d7bdb7f653311baefa39d7dd5fa6022
13 changes: 1 addition & 12 deletions apps/settings/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,8 +1555,7 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
}

/* various */
&#grid-header,
&#new-user {
&#grid-header {
@include position('sticky');
align-self: normal;
background-color: var(--color-main-background);
Expand All @@ -1568,18 +1567,8 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
}
}

// separate prop to set initial value to top: 50px
&#new-user {
height: 120px;

.row {
padding-top: 50px;
}
}

&#grid-header {
color: var(--color-text-maxcontrast);
z-index: 60; /* above new-user */
border-bottom-width: thin;

#headerDisplayName,
Expand Down