Skip to content

[stable22] Fix input for groups validation in new user form #30145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Dec 9, 2021
Merged

[stable22] Fix input for groups validation in new user form #30145

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa8b11c
Fix input for groups validation in new user form
danxuliu Nov 29, 2021
bf499c0
Remove no longer needed CSS rules
danxuliu Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix input for groups validation in new user form 
The hidden input used for form validation was not actually hidden since
Nextcloud 22, as the DOM structure changed to show a dialog rather than
adding a row on top of the list when adding new users, so the CSS rules
no longer matched.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Dec 9, 2021
commit aa8b11ca57155b68f7330a5be50f034d7a23dcac
9 changes: 0 additions & 9 deletions apps/settings/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,15 +1560,6 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
&.sticky {
box-shadow: 0 -2px 10px 1px var(--color-box-shadow);
}

/* fake input for groups validation */
input#newgroups {
position: absolute;
opacity: 0;
width: 80% !important;
margin: 0 10%;
z-index: 0;
}
}

// separate prop to set initial value to top: 50px
Expand Down
4 changes: 2 additions & 2 deletions apps/settings/js/vue-settings-apps-users-management.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/settings/js/vue-settings-apps-users-management.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions apps/settings/js/vue-settings-users.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/settings/js/vue-settings-users.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions apps/settings/src/components/UserList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,4 +622,16 @@ export default {
.row::v-deep .multiselect__single {
z-index: auto !important;
}

/* fake input for groups validation */
input#newgroups {
position: absolute;
opacity: 0;
/* The "hidden" input is behind the Multiselect, so in general it does
* not receives clicks. However, with Firefox, after the validation
* fails, it will receive the first click done on it, so its width needs
* to be set to 0 to prevent that ("pointer-events: none" does not
* prevent it). */
width: 0;
}
</style>