Only wildcard search if enumeration is allowed #30156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
nickvergessen
requested review from
a team,
CarlSchwan,
artonge,
juliusknorr and
skjnldsv
nickvergessen
commented
Dec 8, 2021
CarlSchwan
reviewed
Dec 8, 2021
CarlSchwan
approved these changes
Dec 8, 2021
skjnldsv
approved these changes
Dec 8, 2021
nickvergessen
commented
Dec 8, 2021
nickvergessen
commented
Dec 8, 2021
Member
Author
|
Fixed more entry points to first specify a limit where we only use the first entry anyway, use strict search where we only work with a full value anyway (like resolving a known cloudid) and opted out of the system addressbook when we later on skipped that anyway |
artonge
reviewed
Dec 8, 2021
artonge
approved these changes
Dec 8, 2021
CarlSchwan
reviewed
Dec 8, 2021
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/only-wildcard-search-if-enumeration-is-allowed
branch
from
8a92a21 to
442c68e
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/only-wildcard-search-if-enumeration-is-allowed
branch
from
442c68e to
245cdb4
Compare
artonge
requested changes
Dec 8, 2021
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/only-wildcard-search-if-enumeration-is-allowed
branch
from
f281e35 to
d5cb5a3
Compare
artonge
approved these changes
Dec 8, 2021
CarlSchwan
approved these changes
Dec 8, 2021
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
skjnldsv
deleted the
bugfix/noid/only-wildcard-search-if-enumeration-is-allowed
branch
skjnldsv
added
4. to release
Contributor
|
/backport to 22 |
|
The backport to 22 failed. Please do this backport manually. |
Member
Author
|
/backport to 23 |
|
The backport to 23 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]