Add oauth2_clients migration for Owncloud

[artonge]

Handy script to test the migration. Use it from a nextcloud root directory containing the migration.

#!/bin/bash

set -eu

# Serving ownCloud then Nextcloud at localhost:8080
# Username: admin
# Password: admin

docker kill oc || true
docker rm oc || true

docker run \
	--rm \
	--name oc \
	--detach \
	--env OWNCLOUD_DOMAIN=localhost:8080 \
	--publish 8080:8080 \
	--volume /var/www/owncloud \
	--volume "$PWD":/mnt/local \
	owncloud/server:10.5

docker exec -it oc apt update
docker exec -it oc apt install -y nano rsync

docker exec -it oc sed -i '9,14d' /var/www/owncloud/config/config.php
docker exec -it oc occ app:enable oauth2
docker exec -it oc occ market:install calendar
docker exec -it oc occ app:enable configreport
docker exec -it oc cp /var/www/owncloud/config/config.php /var/www/config.php

instance=""
read -rp "> Double press enter to start the migration." instance

docker exec -it oc rsync --delete --recursive --human-readable --exclude .git --exclude node_modules /mnt/local/ /var/www/owncloud
docker exec -it oc cp /var/www/config.php /var/www/owncloud/config/config.php
docker exec -it oc chown -R www-data:www-data /var/www/owncloud

docker exec -it oc occ upgrade -vvv || true

occ db:convert-filecache-bigint
occ db:add-missing-columns
occ db:add-missing-indices
occ db:add-missing-primary-keys

# Use this command to copy your change in MigrateOauthTables.php to the docker container.
# docker exec -it oc cp /mnt/local/lib/private/Repair/Owncloud/MigrateOauthTables.php /var/www/owncloud/lib/private/Repair/Owncloud/MigrateOauthTables.php

[ChristophWurst]

Maybe I just haven't seen any such code before, but building those migrations by hand and outside of regular migrations feels like something is off.

Why is this not done in a regular migration?

[artonge]

It is not a regular migration but a repair step. I took inspiration from existing ones: https://github.com/nextcloud/server/tree/master/lib/private/Repair/Owncloud. Should we use another approach?

[artonge]

/backport to stable23

[artonge]

/backport to stable22

[artonge]

Limiting backport to stable22 for now. Should we backport this to older versions too? Not sure if the migration path is OC v10 -> NC20 -> ... or OC v10 -> NC latest

[artonge]

/rebase

[artonge]

/rebase

[PVince81]

👍