Prevent loading images that would require too much memory. #30291
Conversation
fancycode
force-pushed
the
image-memory-limit
branch
3 times, most recently
from
9d98b3b to
87c4ba5
Compare
fancycode
force-pushed
the
image-memory-limit
branch
from
87c4ba5 to
e542852
Compare
nickvergessen
requested review from
a team,
come-nc,
nickvergessen and
skjnldsv
and removed request for
a team
|
Hey @fancycode , could you address the comments ? :) |
Happy new year to you, too. I just came back from vacation today and are going through my inbox. Will address the comments as soon as possible. |
|
All comments addressed. Commits should be squashed and the text of the first commit should be adjusted (limit is now read from config.php instead of the app config) - I can do this before merging. |
For most image formats, the header specifies the width/height. PHP allocates an image object from that size, even if the actual image data is much smaller. This image object size is not limited by the limit configured in PHP. The memory limit can be configured through "config.php" setting "preview_max_memory" and defaults to 128 MBytes which should be enough for most images without filling up all memory. Signed-off-by: Joachim Bauch <[email protected]>
fancycode
force-pushed
the
image-memory-limit
branch
from
5b4e1a8 to
d3d65e5
Compare
|
Commits are squashed and the message is updated, so this is ready to merge from my side. |
blizzz
added
4. to release
|
Thanks for merging. Probably would be good to also backport this change to all versions that still receive security updates. |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
For most image formats, the header specifies the width/height. PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited by the limit configured in PHP.
The memory limit can be configured through config setting "preview_max_memory" and defaults to 128 MBytes which should be enough for most images without filling up all memory.
Signed-off-by: Joachim Bauch [email protected]