Skip to content

fix overlapping in the help settings section #30322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Dec 20, 2021
Merged

fix overlapping in the help settings section #30322

artonge merged 1 commit into from
Dec 20, 2021

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 17, 2021 •
edited
Loading

This is best reviewed like this https://github.com/nextcloud/server/pull/30322/files?diff=unified&w=1

Before After
image image

Signed-off-by: szaimen [email protected]

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/fix-help-settings-overlapping \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen marked this pull request as ready for review December 17, 2021 20:41
@szaimen szaimen added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Dec 17, 2021
@szaimen szaimen added this to the Nextcloud 24 milestone Dec 17, 2021
@szaimen szaimen requested review from a team, PVince81, artonge, juliusknorr and skjnldsv and removed request for a team December 17, 2021 20:42
@szaimen
Copy link
Contributor Author

szaimen commented Dec 17, 2021

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Dec 17, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Dec 17, 2021

/backport to stable21

@artonge
Copy link
Contributor

artonge commented Dec 20, 2021

CI failure unrelated.

@artonge artonge merged commit e60ae8a into master Dec 20, 2021
@artonge artonge deleted the enh/noid/fix-help-settings-overlapping branch December 20, 2021 09:27
This was referenced Dec 20, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen @artonge @skjnldsv