Skip to content

improve accessibility settings on mobile #30363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 3 commits into from
Jan 14, 2022
Merged

improve accessibility settings on mobile #30363

szaimen merged 3 commits into from
Jan 14, 2022

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 21, 2021 •
edited
Loading

Before After
192 168 146 128_8443_index php_settings_user_accessibility(Moto G4) (1) 192 168 146 128_8443_index php_settings_user_accessibility(Moto G4)

Signed-off-by: szaimen [email protected]

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/accessibility-settings-mobile \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Dec 21, 2021
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2021
@szaimen szaimen marked this pull request as ready for review December 21, 2021 11:36
@szaimen szaimen requested review from a team, PVince81, Pytal and artonge and removed request for a team December 21, 2021 11:36
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch 2 times, most recently from 86a91f6 to bc2ad3a Compare December 21, 2021 11:44
@nextcloud-command nextcloud-command force-pushed the enh/noid/accessibility-settings-mobile branch from bc2ad3a to 24dc3d5 Compare December 21, 2021 11:45
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch from 24dc3d5 to 63ce951 Compare December 21, 2021 11:51
@szaimen
Copy link
Contributor Author

szaimen commented Dec 21, 2021

Does someone has an idea why Lint / php-cs check (pull_request) Failing after 1m — php-cs check fails? I didn't modify any PHP file so it is probably a false-positive?

skjnldsv
skjnldsv reviewed Dec 21, 2021
View reviewed changes
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 21, 2021
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch 2 times, most recently from 0071cbb to c8d461e Compare December 21, 2021 20:08
szaimen
szaimen commented Dec 21, 2021
View reviewed changes
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2021
@szaimen szaimen requested a review from skjnldsv December 21, 2021 20:25
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch from c8d461e to 1b862a6 Compare December 23, 2021 10:28
@szaimen szaimen requested a review from CarlSchwan December 23, 2021 10:29
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch from cd3fe46 to fdd252f Compare December 23, 2021 11:31
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch from 8fbca83 to 32c9d9a Compare January 10, 2022 11:48
@szaimen
Copy link
Contributor Author

szaimen commented Jan 10, 2022

/rebase

done manually :)

@szaimen
improve accessibility settings on mobile
78cab4b 
Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen
address review
cd6faf2 
Signed-off-by: szaimen <[email protected]>
@szaimen
address 2nd review
d11f235 
Signed-off-by: szaimen <[email protected]>
@szaimen szaimen force-pushed the enh/noid/accessibility-settings-mobile branch from 32c9d9a to d11f235 Compare January 10, 2022 16:31
@artonge artonge requested review from a team and artonge January 10, 2022 18:30
@szaimen szaimen requested review from CarlSchwan, jancborchardt, nimishavijay and skjnldsv and removed request for CarlSchwan and skjnldsv January 13, 2022 14:37
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2022
@szaimen szaimen merged commit 6a7b088 into master Jan 14, 2022
@szaimen szaimen deleted the enh/noid/accessibility-settings-mobile branch January 14, 2022 09:11
@szaimen
Copy link
Contributor Author

szaimen commented Jan 14, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Jan 14, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Jan 14, 2022

/backport to stable21

@szaimen szaimen restored the enh/noid/accessibility-settings-mobile branch January 14, 2022 09:15
@szaimen szaimen deleted the enh/noid/accessibility-settings-mobile branch January 14, 2022 09:16
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: accessibility feature: settings

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

6 participants

@szaimen @artonge @skjnldsv @CarlSchwan @Pytal