Skip to content

Conversation

@nextcloud-command
Copy link
Contributor

Auto-generated update psalm-baseline.xml with fixed psalm warnings

@nextcloud-command nextcloud-command requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a team December 24, 2021 04:10
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the job, it basically clears the baseline 🤔.

@MichaIng
Copy link
Member

Psalm in the baseline update workflow does believe it:

> psalm '--monochrome' '--no-progress' '--output-format=text' '--update-baseline'
------------------------------
1862 errors fixed

Checking what changed between the last run which didn't see all errors fixed (22. Dez) to the first which did (23. Dez):

  • Composer v2.1.14 vs v2.2.1

All installed dependencies match 100%. Major change in composer is: composer/composer#10314
One thing that could be tested quickly is adding the --no-interaction/-n flag. Though since Psalm runs through, it does seem to be the issue on first sight. Strange also that the Psalm CI tests work fine with the same Composer version and without these flags, showing correctly the at time of writing 71 fixed errors.

@MichaIng
Copy link
Member

Closing as of #30409 which should trigger a correct new PR tonight.

@MichaIng MichaIng closed this Dec 31, 2021
@MichaIng MichaIng deleted the automated/noid/psalm-baseline-update-1640319048 branch December 31, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews automated pr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants