Skip to content

Refine files comments design #30412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quentinguidee wants to merge 1 commit into from
Closed

Refine files comments design #30412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/comments/js/comments-app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/comments/js/comments-app.js.map
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 12 additions & 6 deletions apps/comments/src/components/Comment.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,18 +247,21 @@ $comment-padding: 10px;

.comment {
position: relative;
padding: $comment-padding 0 $comment-padding * 1.5;
padding: $comment-padding;

&:first-of-type {
padding-top: 0;
}

&__header {
display: flex;
align-items: center;
min-height: 44px;
padding: $comment-padding / 2 0;
}

&__author,
&__actions {
margin-left: $comment-padding !important;
margin-left: $comment-padding * 1.5 !important;
}

&__author {
Expand All @@ -277,8 +280,7 @@ $comment-padding: 10px;
&__editor,
&__message {
position: relative;
// Avatar size, align with author name
padding-left: 32px + $comment-padding;
margin-top: 6px;
}

&__submit {
Expand Down Expand Up @@ -308,8 +310,12 @@ $comment-padding: 10px;
&__message {
white-space: pre-wrap;
word-break: break-word;
max-height: 70px;
max-height: 84px;
overflow: hidden;
padding: 6px 12px;
background-color: var(--color-background-hover);
border-radius: var(--border-radius-large);

&--expanded {
max-height: none;
overflow: visible;
Expand Down