[stable23] Fix rendering app authors with homepage or email #30431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
ChristophWurst,
GretaD,
Pytal,
skjnldsv,
szaimen and
tcitworld
skjnldsv
approved these changes
Dec 30, 2021
GretaD
approved these changes
Dec 30, 2021
Contributor
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/30413/stable23
branch
from
0785f57 to
25c6acc
Compare
ChristophWurst
added
the
4. to release
MichaIng
approved these changes
Jan 4, 2022
When the first author of an app doesn't have homepage/email attributes set in info.xml then any further author was rendered as `[object Object]` due to the complex XML node seralized to a JavaScript string. The logic was fixed so that it converts any of the authors to simple text. Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
MichaIng
force-pushed
the
backport/30413/stable23
branch
from
25c6acc to
df21ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #30413