Skip to content

[stable23] Make sure to get file model in template picker #30449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Jan 3, 2022
Merged

[stable23] Make sure to get file model in template picker #30449

artonge merged 1 commit into from
Jan 3, 2022

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Dec 30, 2021 •
edited by artonge
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #30440

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.1 milestone Dec 30, 2021
@artonge
Copy link
Contributor

artonge commented Dec 30, 2021

/compile amend /

@julien-nc
Copy link
Member

julien-nc commented Dec 30, 2021

I'll make some real life test of those backports.

@nextcloud-command
fix template picker for file actions using the fileInfoModel
dccd2a6 
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@julien-nc
Copy link
Member

julien-nc commented Jan 3, 2022

@artonge CI failures seem unrelated.

  • continuous-integration/drone/pr -> acceptance-users: it's a test about "users navigation without disabled users"
  • static-code-analysis-ocp fails with this error:
Cannot find file composer-bin-proxy:/home/runner/work/server/server/vendor-bin/psalm/vendor/vimeo/psalm/psalm to include

Are we ok to merge this?

@artonge artonge merged commit 58dc589 into stable23 Jan 3, 2022
@artonge artonge deleted the backport/30440/stable23 branch January 3, 2022 09:42
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
Merged
6 tasks
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@julien-nc julien-nc julien-nc approved these changes

@MichaIng MichaIng MichaIng approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

bug feature: templates

Projects

None yet

Milestone

Nextcloud 23.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge @julien-nc @MichaIng