-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Remove inefficient fed share scanner #30499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inefficient fed share scanner #30499
Conversation
1115141 to
a8dea0f
Compare
|
cool, no failure related to federated sharing
|
|
I've done a manual test as follows:
After the sync, the new folder "e" got synced. So it all works fine with this PR 😀 Please review! |
a8dea0f to
6b081a7
Compare
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, but all good 🚀
6b081a7 to
8844b97
Compare
Remove scanAll which relies on the "shareinfo" endpoint that returns the full cache tree. The latter can become big for big shares and result in timeouts. Furthermode, the full tree would be retrieved again for each and every detected change which can become expensive quickly. Signed-off-by: Vincent Petry <[email protected]>
8844b97 to
ce31914
Compare
|
JS failure unrelated, merging |
|
Does this qualify for backport? |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
thanks for your usual reminders 😄 |
Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.
As discussed with @icewind1991
Draft for now, needs more extensive testing to confirm that the default scanner will work correctly for federated shares.
Fixes #29941