-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Avoid zero division in setup checks #30533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable23 |
|
Shouldn't it be |
|
It's the free memory and the max cached keys (not the used memory/keys). In both cases, when they are null, nothing can be cached anymore, hence the warning as a performance recommendation makes sense. Not sure whether any max value can be actually set to Did some tests:
Drone failure is unrelated. |
|
Another thing: Is there probably a flag for one of the CI checks/tools to fail on division by unverified variables? |
4cfba89 to
21829d6
Compare
|
jsunit failure is unrelated, same as here: #30557 |
|
/rebase |
Fixes: #30532 Signed-off-by: MichaIng <[email protected]>
21829d6 to
79cdb56
Compare
Fixes: #30532