fix: only use jquery once it is available #30571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publicpage.js is loaded very early and cannot rely on jquery being loaded already. Move the use of `$` into the `DomContentLoaded` handler. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
fix/missing-jquery
branch
from
9a67578 to
94554c4
Compare
Contributor
Author
|
Noticed this because cypress tests in text started failing complaining: This seems to be the easiest fix for now. Could also rewrite this without relying on jquery - but i guess that's for another time. |
artonge
approved these changes
Jan 10, 2022
Contributor
|
/rebase |
skjnldsv
approved these changes
Jan 10, 2022
Member
|
Backport? |
Contributor
|
/backport to stable23 |
Contributor
|
/backport to stable22 |
Contributor
|
/backport to stable21 |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicpage.js is loaded very early and cannot rely on jquery being loaded already.
Move the use of
$into theDomContentLoadedhandler.