Skip to content

[stable23] Use npm ci when running JS tests #30580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 5 commits into from
Jan 11, 2022
Merged

[stable23] Use npm ci when running JS tests #30580

PVince81 merged 5 commits into from
Jan 11, 2022

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Jan 10, 2022

Manual backport of #30567 to stable23.
Ran "npm i" again to update the lock file, and recompiled the assets.

@PVince81
Use npm ci when running JS tests
7dcbcd2 
This makes sure that the pinned versions are selected correctly.
Fixes the colors.js incident.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Update node deps for JS tests
60e3640 
Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Fix JS tests after test lib updates
4e4797b 
Prevent XHR during load by checking window.TESTING.
Adjust some expected values.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Recompile JS
c948cee 
Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 added the 3. to review Waiting for reviews label Jan 10, 2022
@PVince81 PVince81 added this to the Nextcloud 23.0.1 milestone Jan 10, 2022
@PVince81 PVince81 self-assigned this Jan 10, 2022
@PVince81 PVince81 mentioned this pull request Jan 10, 2022
Merged
@PVince81
Copy link
Member Author

PVince81 commented Jan 10, 2022

some complications :-/

I'll have a look.

@julien-nc
Copy link
Member

julien-nc commented Jan 10, 2022

Can we run those test locally only by running autotest-js.sh?
I get this on master and bugfix/noid/npm-ci-for-karma/stable23 branches:

1) generates plural with default function when no forms specified
     OC.L10N tests plurals
     Expected '0 Datei herunterladen' to equal '0 Dateien herunterladen'.
    at checkPlurals (core/js/tests/specs/l10nSpec.js:74:6)
    at Object.<anonymous> (core/js/tests/specs/l10nSpec.js:109:4)

@PVince81
Copy link
Member Author

PVince81 commented Jan 10, 2022 •
edited
Loading

Can we run those test locally only by running autotest-js.sh? I get this on master and bugfix/noid/npm-ci-for-karma/stable23 branches:

1) generates plural with default function when no forms specified
     OC.L10N tests plurals
     Expected '0 Datei herunterladen' to equal '0 Dateien herunterladen'.
    at checkPlurals (core/js/tests/specs/l10nSpec.js:74:6)
    at Object.<anonymous> (core/js/tests/specs/l10nSpec.js:109:4)

yes you can.

and I'm sad to see that you're getting even different errors than what I see locally 😢

@PVince81
Copy link
Member Author

PVince81 commented Jan 10, 2022

the tests passed on CI though now for stable23

@artonge
Copy link
Contributor

artonge commented Jan 10, 2022 •
edited
Loading

Can we run those test locally only by running autotest-js.sh?

They currently have to be run with npm 6, which could explain your error.

@PVince81 PVince81 merged commit 67fcbac into stable23 Jan 11, 2022
@PVince81 PVince81 deleted the bugfix/noid/npm-ci-for-karma/stable23 branch January 11, 2022 07:53
@blizzz blizzz mentioned this pull request Jan 14, 2022
Merged
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@PVince81 PVince81

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 23.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@PVince81 @julien-nc @artonge @skjnldsv