Trigger "changeDirectory" event on URL change #30593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
CarlSchwan,
artonge,
juliusknorr and
miaulalala
PVince81
changed the title
Member
Author
|
oh, I need to adjust the JS tests |
miaulalala
approved these changes
Jan 11, 2022
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
As er our debug sesh - LGTM :)
When using the browser back button or clicking on sections on the left sidebar (like favorites), the "changeDirectory" jQuery event did not get called, so apps like recommendations would not notice the directory change. This fixes the issue by also setting changeUrl to true when the file list's directory got changed as a result from a URL change. Added optional changedThroughUrl argument to make sure the event recipient knows if the change was done through a URL change and make it possible prevent a loop in the onDirectoryChange handler that actually changes the URL when the origin was already from a URL change. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/19048/fix-changedirectory-recommendations
branch
from
1ca7165 to
809e305
Compare
Member
Author
|
I had to resort to a more complicated fix to prevent the "URL changed -> then change URL" loop which broke the tests and is potentially dangerous. please re-review |
juliusknorr
approved these changes
Jan 12, 2022
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
artonge
approved these changes
Jan 12, 2022
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the browser back button or clicking on sections on the left
sidebar (like favorites), the "changeDirectory" jQuery event did not get
called, so apps like recommendations would not notice the directory
change.
This fixes the issue by also setting changeUrl to true when the file
list's directory got changed as a result from a URL change.
Note that in the past this argument was there to prevent repushing the
same URL to the history stack but is obsolete already as there's a check
in place to not push again whatever is already there.
Fixes #19048
I've tested this PR with both scenarios from the ticket.