Fix file picker not respecting hidden files settings #30597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
approved these changes
Jan 11, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 good enough as a quick fix for files app
hopefully we can move this to initial states later on
CarlSchwan
force-pushed
the
fix/30589/hide-hidden-file-dialog
branch
from
c89bf6d to
e14477a
Compare
tcitworld
reviewed
Jan 11, 2022
CarlSchwan
force-pushed
the
fix/30589/hide-hidden-file-dialog
branch
from
e14477a to
07d3912
Compare
artonge
approved these changes
Jan 11, 2022
Member
Author
|
@PVince81 Can you re-review now that there is some new tests? :D |
Member
Author
|
actually the PR with the new tests is https://github.com/nextcloud/server/pull/30600/files. Sorry messed up my tabs |
Member
|
/compile amend / |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
nextcloud-command
force-pushed
the
fix/30589/hide-hidden-file-dialog
branch
from
07d3912 to
10a463b
Compare
This will only respect the setting inside the file app. For other apps we will either need to do an API call or add an input field with the same idea to spare a blocking api call. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
fix/30589/hide-hidden-file-dialog
branch
from
10a463b to
1fa58be
Compare
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only respect the setting inside the file app. For other apps
we will either need to do an API call or add an input field with the
same idea to spare a blocking api call.
Related to #30589
Signed-off-by: Carl Schwan [email protected]