Skip to content

Improve install process #30615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jan 17, 2022
Merged

Improve install process #30615

skjnldsv merged 1 commit into from
Jan 17, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jan 12, 2022 •
edited
Loading

Now with the satisfaction of clicking a button :)

Before After

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: install and update ux labels Jan 12, 2022
@Pytal Pytal added this to the Nextcloud 24 milestone Jan 12, 2022
@Pytal Pytal requested a review from a team January 12, 2022 03:50
@Pytal Pytal self-assigned this Jan 12, 2022
@Pytal Pytal requested review from PVince81, artonge and skjnldsv and removed request for a team January 12, 2022 03:50
@Pytal

This comment has been minimized.

Sign in to view
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2022

/backport to stable22

@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2022

/backport to stable21

@nextcloud-command nextcloud-command force-pushed the enh/recommended-apps-installation branch from c74ebdb to fa57f34 Compare January 12, 2022 03:57
artonge
artonge requested changes Jan 12, 2022
View reviewed changes
@artonge
Copy link
Contributor

artonge commented Jan 12, 2022

I would say having the list of recommended apps before starting the install is nice too. Not sure if we should go on with this change.

PVince81
PVince81 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

optionally see Louis' comment

@Pytal Pytal force-pushed the enh/recommended-apps-installation branch from fa57f34 to accba47 Compare January 12, 2022 19:43
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2022 •
edited
Loading

Now updated code and screenshots to show the recommended apps alongside the install button

@Pytal

This comment has been minimized.

Sign in to view
@Pytal Pytal requested a review from artonge January 12, 2022 19:54
@nextcloud-command nextcloud-command force-pushed the enh/recommended-apps-installation branch from accba47 to 06d2a04 Compare January 12, 2022 19:59
artonge
artonge approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks code !

szaimen
szaimen approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 👍

Maybe we could think about removing the checkbox now that you need to press a button to start the installation of the apps either way:
image

Also we could think about renaming the desciption of the button from Finish installation to Continue installation as this is not the last step if you don't uncheck the Install recommended apps checkbox?

@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 14, 2022
@Pytal Pytal force-pushed the enh/recommended-apps-installation branch from 06d2a04 to 4e24b56 Compare January 14, 2022 19:50
@Pytal

This comment has been minimized.

Sign in to view
@Pytal
Copy link
Member Author

Pytal commented Jan 14, 2022

Checkbox removed and wording updated, plus updated screenshots

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 14, 2022
@Pytal Pytal changed the title Improve recommended apps installation Improve installation Jan 14, 2022
@Pytal Pytal force-pushed the enh/recommended-apps-installation branch from 4e24b56 to cf0f4db Compare January 14, 2022 19:58
@nextcloud-command nextcloud-command force-pushed the enh/recommended-apps-installation branch from cf0f4db to cee875c Compare January 14, 2022 19:58
@Pytal
Improve installation pages
2276876 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the enh/recommended-apps-installation branch from cee875c to 2276876 Compare January 14, 2022 19:59
@Pytal Pytal changed the title Improve installation Improve install process Jan 14, 2022
szaimen
szaimen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍
(but didn't review the code)

Thanks for adressing my comment :)

@skjnldsv skjnldsv merged commit 396e5cb into master Jan 17, 2022
@skjnldsv skjnldsv deleted the enh/recommended-apps-installation branch January 17, 2022 08:16
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 17, 2022 •
edited by Pytal
Loading

The backport to stable23 failed. Please do this backport manually.

backport to stable23 #30747

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 17, 2022 •
edited by Pytal
Loading

The backport to stable22 failed. Please do this backport manually.

backport to stable22 #30748

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 17, 2022 •
edited by Pytal
Loading

The backport to stable21 failed. Please do this backport manually.

backport to stable21 #30749

This was referenced Jan 19, 2022
Merged
Merged
Merged
@tilosp tilosp mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: install and update

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal @artonge @PVince81 @skjnldsv @szaimen