Remove shortFooter/longFooter to avoid unnecessary navigation loading #30625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
added
enhancement
3. to review
juliusknorr
requested review from
a team,
CarlSchwan,
icewind1991 and
nickvergessen
and removed request for
a team
12 tasks
nickvergessen
approved these changes
Jan 12, 2022
CarlSchwan
approved these changes
Jan 12, 2022
Member
|
@juliushaertl should this be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any usages of those properties on the
_themeglobal which I'd consider private API in the frontend code and fetching them can be quite expensive with loading all available entries in the navigation manager:server/apps/theming/lib/ThemingDefaults.php
Line 194 in da73990
server/lib/private/NavigationManager.php
Line 113 in a942364