[stable20] Optimize FileSystemTags workflow for groupfolder #30681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #28774 we disabled the caching for the groupfolder application since it worked due to the fact that in groupfolders, getFileIds could be called with the same $cacheId and path for actually different groupfolders. This revert this change and instead add the folderId from the groupFolder to the cacheId. This solve the issue of the uniqueness of the cacheId inside GroupFolder. Downside is that we introduce groupfolder specific implementation inside the server repo. The seconf optimization is to not consider paths starting with __groupfolders in executeCheck. This is due to the fact that files in the groupfolder application call two times executeCheck one time with the url __groupfolder/<folderId>/<path> and the other time with <path>. The first time will always return an empty systemTags array while the second call will return the correct system tags. Signed-off-by: Carl Schwan <[email protected]>
Don't call twice $cache->getId Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
blizzz,
come-nc,
nickvergessen and
st3iny
Member
|
Do we still backport to stable20? I thought only the last 3 version are targets for backports (21 - 23). |
Member
For some specific change, we still do e.g. #30668 |
Member
|
php cs is not happy |
nickvergessen
added
2. developing
Member
The backport is heavily broken, half of the diff is missing. |
CarlSchwan
force-pushed
the
backport/30531/stable20
branch
from
9636384 to
ab01174
Compare
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
backport/30531/stable20
branch
from
ab01174 to
e5c54bd
Compare
skjnldsv
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #30531