Skip to content

[stable21] Always call flush() as getAllKeys() is broken #30775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jan 27, 2022
Merged

[stable21] Always call flush() as getAllKeys() is broken #30775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Always call flush() as getAllKeys() is broken 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @skjnldsv
come-nc authored and skjnldsv committed Jan 27, 2022
commit 8f1199453702c0d301c46225d2a1fc4689b62d21
23 changes: 2 additions & 21 deletions lib/private/Memcache/Memcached.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,27 +134,8 @@ public function remove($key) {
}

public function clear($prefix = '') {
$prefix = $this->getNameSpace() . $prefix;
$allKeys = self::$cache->getAllKeys();
if ($allKeys === false) {
// newer Memcached doesn't like getAllKeys(), flush everything
self::$cache->flush();
return true;
}
$keys = [];
$prefixLength = strlen($prefix);
foreach ($allKeys as $key) {
if (substr($key, 0, $prefixLength) === $prefix) {
$keys[] = $key;
}
}
if (method_exists(self::$cache, 'deleteMulti')) {
self::$cache->deleteMulti($keys);
} else {
foreach ($keys as $key) {
self::$cache->delete($key);
}
}
// Newer Memcached doesn't like getAllKeys(), flush everything
self::$cache->flush();
return true;
}

Expand Down