Fix accessing undefined offsets

[CarlSchwan]

Move this to inside the else clause of the count($matches)

Signed-off-by: Carl Schwan [email protected]

[nickvergessen]

🙈

[CarlSchwan]

/backport to stable23

[CarlSchwan]

/backport to stable22

[PVince81]

👍 as discussed

[PVince81]

samba test failed without results

since this PR is connected, I've restarted the build just in case, hoping for the best...

[CarlSchwan]

samba test failed without results

since this PR is connected, I've restarted the build just in case, hoping for the best...

It indeed looks connected but at the same time it's also broken on master. 😱

Maybe the tests broke with the PR that added this feature?

[CarlSchwan]

Let's focus on fixing the tests on #30796

[skjnldsv]

samba test failed without results
since this PR is connected, I've restarted the build just in case, hoping for the best...

It indeed looks connected but at the same time it's also broken on master. scream

Maybe the tests broke with the PR that added this feature?

not connected, this was here after the SMB bump of yesterday, Robin have been notified :)

[solracsf]

@skjnldsv my suggestion was discarded :)

[skjnldsv]

@acsfer what do you mean?

[solracsf]

@skjnldsv see

server/apps/files_external/lib/Lib/Backend/SMB.php

Line 115 in 29413b9

$username = $matches[1];;

(double ;; on master and backports...)

[nickvergessen]

It works never the less?

[CarlSchwan]

It works never the less?

yeah, it will work. The additional semicolon is just an empty statement, I will submit Monday a PR to fix it in master but there is no need to backport this.

[solracsf]

Sure, but merge a PR with this "typo" after it was pointed-out it's a bit, let's say, strange... :)
(and same thing for the backports)

[CarlSchwan]

I'm not sure where this was pointed out. Did you maybe forgot to submit the comment? I only see your message about your suggestions being discarded but this one after merging this PR.