Skip to content

Collaboration, MailPlugin: Protect access to a potentially missing array component by ??. #30957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Feb 29, 2024
Merged

Collaboration, MailPlugin: Protect access to a potentially missing array component by ??. #30957

skjnldsv merged 1 commit into from
Feb 29, 2024

Conversation

@rotdrop
Copy link
Contributor

@rotdrop rotdrop commented Feb 1, 2022

Otherwise I get errors like

Error: Trying to access array offset on value of type null at /var/www/localhost/htdocs/nextcloud-git/lib/private/Collaboration/Collaborators/MailPlugin.php#178 /var/www/localhost/htdocs/nextcloud-git/lib/private/Log/ErrorHandler.php:95

and

Exception: OC\Federation\CloudIdManager::resolveCloudId(): Argument #1 ($cloudId) must be of type string, null given, called in /var/www/localhost/htdocs/nextcloud-git/lib/private/Collaboration/Collaborators/MailPlugin.php on line 178 in file '/var/www/localhost/htdocs/nextcloud-git/lib/private/Federation/CloudIdManager.php' line 58 /var/www/localhost/htdocs/nextcloud-git/lib/private/AppFramework/Http/Dispatcher.php:158

CarlSchwan
CarlSchwan reviewed Feb 1, 2022
View reviewed changes
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz removed this from the Nextcloud 28 milestone Nov 23, 2023
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@rotdrop @skjnldsv
fix(collaboration): collaboration MailPlugin: Protect access to a pot…
4933330 
…entially missing array component by ??.

Signed-off-by: Claus-Justus Heine <[email protected]>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Feb 27, 2024
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, ChristophWurst, miaulalala, nfebe and sorbaugh and removed request for a team February 27, 2024 16:52
@skjnldsv skjnldsv force-pushed the bugfix/collaboration-mail-plugin-fix-array-access-resulting-in-type-error branch from 710c3cc to 4933330 Compare February 27, 2024 16:53
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2024
@skjnldsv skjnldsv merged commit 747c391 into nextcloud:master Feb 29, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Feb 29, 2024

/backport to stable28

@skjnldsv
Copy link
Member

skjnldsv commented Feb 29, 2024

/backport to stable27

@skjnldsv
Copy link
Member

skjnldsv commented Feb 29, 2024

/backport to stable26

@backportbot backportbot bot mentioned this pull request Feb 29, 2024
Merged
This was referenced Feb 29, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Sep 17, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@rotdrop @skjnldsv @ChristophWurst @miaulalala @CarlSchwan @blizzz