Skip to content

[stable22] Add primary key for ratelimit table #30966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 4 commits into from
Mar 10, 2022
Merged

[stable22] Add primary key for ratelimit table #30966

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3532802
Add a primary key to ratelimit_entries table
nickvergessen Dec 13, 2021
4fe5cef
Make the DB query simpler (as we just deleted all other entries)
nickvergessen Dec 13, 2021
1e2e3d1
Update autoloader
nickvergessen Mar 10, 2022
c818ac6
Bump version
nickvergessen Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the DB query simpler (as we just deleted all other entries) 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Mar 10, 2022
commit 4fe5cef95a7b508a7ddf6eb21335363d984da3a6
3 changes: 0 additions & 3 deletions lib/private/Security/RateLimiting/Backend/DatabaseBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ private function getExistingAttemptCount(
->from(self::TABLE_NAME)
->where(
$qb->expr()->eq('hash', $qb->createNamedParameter($identifier, IQueryBuilder::PARAM_STR))
)
->andWhere(
$qb->expr()->gte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATE))
);

$cursor = $qb->executeQuery();
Expand Down