Skip to content

Fix Calendar sends duplicate notifications if there is an additional attendee (#21370) #30980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kominoshja wants to merge 3 commits into from
Closed

Fix Calendar sends duplicate notifications if there is an additional attendee (#21370) #30980

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6497f47
Fix #21370
kominoshja Feb 2, 2022
b561f15
Update Backend.php
kominoshja Mar 8, 2022
38ae202
Merge branch 'master' into patch-1
miaulalala Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/dav/lib/CalDAV/Reminder/Backend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ public function getRemindersToProcess():array {
->from('calendar_reminders', 'cr')
->where($query->expr()->lte('cr.notification_date', $query->createNamedParameter($this->timeFactory->getTime())))
->join('cr', 'calendarobjects', 'co', $query->expr()->eq('cr.object_id', 'co.id'))
->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id'));
->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id'))
->groupBy(['cr.event_hash','cr.type','cr.uid']);
Copy link
Member

@nickvergessen nickvergessen Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails on some DB configurations:
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by

Copy link
Contributor

@miaulalala miaulalala Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know. I guess I have to do the grouping in memory.

Copy link
Member

@ChristophWurst ChristophWurst Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select those columns on L67 as well, then you can still run this on the DB

Copy link
Member

@nickvergessen nickvergessen Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select those columns on L67 as well

That's not right it. It's the other way around: All items that are selected need to be aggregated.
But I agree, if we previously did not group on db level, just group manually in php.

$stmt = $query->execute();

return array_map(
Expand Down