Only allow avatars in 64 and 512 pixel size #31010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
CarlSchwan
approved these changes
Feb 4, 2022
szaimen
approved these changes
Feb 4, 2022
szaimen
added
4. to release
Member
|
integration tests for avatar needs adjusting as well @nickvergessen |
szaimen
added
2. developing
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/fixed-avatar-sizes
branch
from
a419e16 to
6dd60b6
Compare
nickvergessen
added
3. to review
Member
Author
|
Pushed and also enforcing size on guest avatars now |
juliusknorr
approved these changes
Feb 7, 2022
juliusknorr
added
4. to release
3 tasks
This was referenced Feb 9, 2022
Member
|
backport ? |
Member
Author
|
Might have potential to break various apps, do not recommend. |
mahibi
added a commit
to nextcloud/talk-android
that referenced
this pull request
Mar 2, 2022
necessary because of nextcloud/server#31010 known issue: avatars in chat messages are too big atm Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
added a commit
to nextcloud/talk-android
that referenced
this pull request
Mar 2, 2022
necessary because of nextcloud/server#31010 known issue: avatars in chat messages are too big atm Signed-off-by: Marcel Hibbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently avatars are requested in lots of different sizes. This means they can not be properly cached by clients and also the server needs to generate them in multiple different versions.
To save requests we from now on only allow 64 and 512 as avatar size.
cc @tobiasKaminsky maybe you can take this into the client team and adjust the requests there as well. The returned images will be 64 and 512 with this PR, but you can increase your own cache hits if you don't request
/avatar/tobi/256which will return the 512 image anyway