-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Expose additional emails in {DAV:}alternate-URI-set #31029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
commented
Feb 5, 2022
3c67295 to
e672feb
Compare
e672feb to
910c815
Compare
Merged
Merged
910c815 to
45284cc
Compare
fdfaf81 to
b79b689
Compare
Member
Author
|
Can someone restart Drone? |
Member
Could try a no-edit force push? |
b79b689 to
733368f
Compare
This allows iMip invitations to be send with an alternative email as "Reply-To" field. Closes #27201 Signed-off-by: Thomas Citharel <[email protected]>
733368f to
190a71e
Compare
ChristophWurst
approved these changes
May 17, 2022
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PVince81
approved these changes
Jun 10, 2022
Member
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feature: caldav
Related to CalDAV internals
feature: dav
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows iMip invitations to be send with an alternative email as "Reply-To" field.
The emails are provided in the
alternate-URI-setprop, and throughcalendar-user-address-setandemail-address-seton a CalDAV principal.https://github.com/nextcloud/3rdparty/blob/41d5f9752c7e0f2b690480a38ef5b9dddc357166/sabre/dav/lib/CalDAV/Plugin.php#L347-L367
However, it's not possible to find users principals from their alternative emails by filtering through
{http://sabredav.org/ns}email-addressorcalendar-user-address-set(which only use the system email address).server/apps/dav/lib/Connector/Sabre/Principal.php
Lines 299 to 311 in 9c2db7f
Closes #27201