Add a background job to prune outdated sync tokens #31064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
3. to review
tcitworld
requested review from
ChristophWurst,
juliusknorr,
miaulalala and
nickvergessen
Contributor
|
Looks good, but code scanning is complaining a bit :) |
Member
It's merged |
apps/dav/tests/unit/BackgroundJob/PruneOutdatedSyncTokensJobTest.php
Outdated
Show resolved
Hide resolved
tcitworld
added
2. developing
Merged
tcitworld
force-pushed
the
prune-calendar-changes
branch
from
d015e6c to
445a8f0
Compare
Merged
tcitworld
force-pushed
the
prune-calendar-changes
branch
from
445a8f0 to
cb7a189
Compare
Merged
tcitworld
force-pushed
the
prune-calendar-changes
branch
from
cb7a189 to
9898a0f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->setTimeSensitivity(self::TIME_INSENSITIVE); | ||
| } | ||
|
|
||
| public function run($argument) { |
Check notice
Code scanning / Psalm
MissingReturnType
| $this->setTimeSensitivity(self::TIME_INSENSITIVE); | ||
| } | ||
|
|
||
| public function run($argument) { |
Check notice
Code scanning / Psalm
MissingParamType
Merged
Merged
tcitworld
force-pushed
the
prune-calendar-changes
branch
from
9898a0f to
8baac0d
Compare
tcitworld
added
3. to review
ChristophWurst
approved these changes
Oct 2, 2022
miaulalala
approved these changes
Oct 27, 2022
Contributor
|
/rebase |
We remove all outdated sync tokens, based on their auto-incremented ID. By default we only keep the last 10 000, but this can be configurable. Signed-off-by: Thomas Citharel <[email protected]>
nextcloud-command
force-pushed
the
prune-calendar-changes
branch
from
8baac0d to
6f15873
Compare
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove all outdated sync tokens, based on their auto-incremented ID.
By default we only keep the last 10 000, but this can be configurable.
Closes #3349
We can add
if #30945 is merged first.