Skip to content

Revert the 'broken' public page changes #31077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 3 commits into from
Feb 10, 2022
Merged

Revert the 'broken' public page changes #31077

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60a7e36
Revert "Fix loading of the text app in public shared links"
CarlSchwan Feb 8, 2022
16e9e24
Revert "Improve layout for the public download page"
CarlSchwan Feb 8, 2022
f042437
Revert "Add non-breaking space in the file size"
szaimen Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Improve layout for the public download page" 
This reverts commit 2e55ce0.

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed Feb 10, 2022
commit 16e9e242ed85d656347d8d0cd8dec5d55a4d8152
31 changes: 10 additions & 21 deletions core/css/public.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,8 @@
#body-public {
min-height: 100vh;
display: flex;
flex-direction: column;

#content {
flex-grow: 2;
min-height: initial;

/** Center the shared content inside the page */
&.app-files_sharing {
justify-content: center;
align-items: center;
#app-content {
min-height: inherit;
padding-left: 1rem;
padding-right: 1rem;
}
}
}
$footer-height: 65px;

#body-public {
.header-right {

#header-primary-action a {
color: var(--color-primary-text);
}
Expand Down Expand Up @@ -52,6 +35,12 @@
}
}

#content {
// 100% - footer
min-height: calc(100% - #{$footer-height});

}

/** don't apply content header padding on the base layout */
&.layout-base #content {
padding-top: 0;
Expand Down Expand Up @@ -83,8 +72,8 @@
display: flex;
align-items: center;
justify-content: center;
height: $footer-height;
flex-direction: column;
padding: 0.5rem;
p {
text-align: center;
color: var(--color-text-lighter);
Expand Down