Skip to content

[stable23] Don't provide favorite activity settings #31084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Feb 16, 2022
Merged

[stable23] Don't provide favorite activity settings #31084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't provide favorite activity settings 
Since mails and notifications are only available for actions of other users
it does not make sense to allow changing this.
It also prevents the common misunderstanding with
"file was changed inside a favorited folder"

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Feb 9, 2022
commit c3b948776f5630e45dc9d11fa84ea32d258a7f09
12 changes: 10 additions & 2 deletions apps/files/lib/Activity/Settings/FavoriteAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function getPriority() {
* @since 11.0.0
*/
public function canChangeStream() {
return true;
return false;
}

/**
Expand All @@ -71,7 +71,7 @@ public function isDefaultEnabledStream() {
* @since 11.0.0
*/
public function canChangeMail() {
return true;
return false;
}

/**
Expand All @@ -81,4 +81,12 @@ public function canChangeMail() {
public function isDefaultEnabledMail() {
return false;
}

/**
* @return bool True when the option can be changed for the notification
* @since 20.0.0
*/
public function canChangeNotification() {
return false;
}
}