Add version handling to IMigrator #31173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
enhancement/user_migration-version-handling
branch
from
165d8a9 to
a2efe13
Compare
Member
Yes this sounds good, then the migrator itself can decide what to do. For calendar since there are edge cases that don't make sense to handle we'll probably cancel the import on null |
come-nc
force-pushed
the
enhancement/user_migration-version-handling
branch
from
ee0e040 to
98fe083
Compare
3 tasks
come-nc
added
3. to review
Pytal
approved these changes
Feb 15, 2022
Pytal
requested review from
a team,
juliusknorr,
nickvergessen and
skjnldsv
and removed request for
a team
CarlSchwan
reviewed
Feb 17, 2022
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…m source Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
enhancement/user_migration-version-handling
branch
from
98fe083 to
885b790
Compare
PVince81
reviewed
Feb 18, 2022
Member
|
please update autoloaders, the checkers are unhappy |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
ChristophWurst
added
the
pending documentation
Member
|
FYI these changes are not on https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/user_migration.html#register-a-migrator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a trait to implement basic version handling suited for most cases: forbids importing newer versions.
Question:
Maybe we should make the $version parameter of canImport nullable, with null meaning the migrator was not present in the export. In which case the function should return true to run anyway, and false to stop the import as not compatible.
Signed-off-by: Côme Chilliet [email protected]