Skip to content

[stable23] Improve user status revert performance #31192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Feb 23, 2022
Merged

[stable23] Improve user status revert performance #31192

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72413ee
Directly delete the user status instead of getting it a second time
nickvergessen Feb 10, 2022
e2a86b7
Delete the user status without loading it first
nickvergessen Feb 10, 2022
7309e97
Don't include unindexed is_backup in the query, it's ensured by the u…
nickvergessen Feb 11, 2022
2e328fc
Create the backup user status in 1 query instead of 3
nickvergessen Feb 15, 2022
9292834
Do status and predefined message setting in one go
nickvergessen Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't include unindexed is_backup in the query, it's ensured by the u… 
…ser_id leading underscore already

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Feb 15, 2022
commit 7309e979071565da592819991c9d9deb3134a70d
3 changes: 1 addition & 2 deletions apps/user_status/lib/Db/UserStatusMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ public function findByUserId(string $userId, bool $isBackup = false):UserStatus
$qb
->select('*')
->from($this->tableName)
->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)))
->andWhere($qb->expr()->eq('is_backup', $qb->createNamedParameter($isBackup, IQueryBuilder::PARAM_BOOL)));
->where($qb->expr()->eq('user_id', $qb->createNamedParameter($isBackup ? '_' . $userId : $userId, IQueryBuilder::PARAM_STR)));

return $this->findEntity($qb);
}
Expand Down