Skip to content

Use the cache also for UserBackend::getPassword #31218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Mar 2, 2022
Merged

Use the cache also for UserBackend::getPassword #31218

nickvergessen merged 2 commits into from
Mar 2, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 16, 2022

Bildschirmfoto von 2022-02-16 17-55-42

(Screenshot together with #31217 )

@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Feb 16, 2022
@nickvergessen nickvergessen requested review from a team, CarlSchwan, PVince81 and come-nc February 16, 2022 16:59
@nickvergessen nickvergessen force-pushed the techdebt/noid/use-cache-also-for-userbackend-getpassword branch from 97740e4 to 23ef02f Compare February 16, 2022 17:00
@CarlSchwan
Copy link
Member

CarlSchwan commented Feb 17, 2022

Tests are not happy :/

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 18, 2022

Test fixed

PVince81
PVince81 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Mar 2, 2022

acceptance test for users failed
now since this PR is about user management, I've restarted the tests just to be sure

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 2, 2022
@PVince81
Copy link
Member

PVince81 commented Mar 2, 2022

@nickvergessen backport or too risky ?

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 2, 2022

I would consider it after we know an instance that uses Database backend ran good for some days.
In general I think it's fine to backport

@nickvergessen nickvergessen merged commit 18bafef into master Mar 2, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/use-cache-also-for-userbackend-getpassword branch March 2, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups performance 🚀 technical debt

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @CarlSchwan @PVince81 @come-nc