Skip to content

Revert "Set umask before operations that create local files" #31293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bgottschall wants to merge 9 commits into from
Closed

Revert "Set umask before operations that create local files" #31293

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee7acd6
Revert "Merge pull request #25280 from nextcloud/explicit-file-permis…
Feb 21, 2022
78c02f4
* removed unecessary and incomplete chmod in mkdir
Mar 7, 2022
79e971f
* removed spaces
Mar 7, 2022
64060bd
* added umask check
Mar 7, 2022
96dfc78
* fixed umask check
Mar 7, 2022
ec3199f
Merge branch 'master' into revert/explicit-file-permissions
Mar 18, 2022
48f5a51
* forgot umask entry in the testCheck
Mar 22, 2022
e8d33ef
Merge branch 'master' into revert/explicit-file-permissions
Mar 24, 2022
8e25b79
Merge branch 'master' into revert/explicit-file-permissions
Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* added umask check 
Signed-off-by: Björn Gottschall <[email protected]>
  • Loading branch information
Björn Gottschall committed Mar 18, 2022
commit 64060bd8721fe45e24c3b0ca8d155031dff4822c
10 changes: 10 additions & 0 deletions apps/settings/lib/Controller/CheckSetupController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* @author Timo Förster <[email protected]>
* @author Valdnet <[email protected]>
* @author MichaIng <[email protected]>
* @author Björn Gottschall <[email protected]>
*
* @license AGPL-3.0
*
Expand Down Expand Up @@ -793,6 +794,14 @@ protected function imageMagickLacksSVGSupport(): bool {
return extension_loaded('imagick') && count(\Imagick::queryFormats('SVG')) === 0;
}

/**
* Checks if the process umask has owner read/write/execute permissions
* @return bool
*/
protected function hasRecommendedUMask(): bool {
return ((umask() & 0700) === 0700);
}

/**
* @return DataResponse
* @AuthorizedAdminSetting(settings=OCA\Settings\Settings\Admin\Overview)
Expand Down Expand Up @@ -850,6 +859,7 @@ public function check() {
'isDefaultPhoneRegionSet' => $this->config->getSystemValueString('default_phone_region', '') !== '',
SupportedDatabase::class => ['pass' => $supportedDatabases->run(), 'description' => $supportedDatabases->description(), 'severity' => $supportedDatabases->severity()],
'temporaryDirectoryWritable' => $this->isTemporaryDirectoryWritable(),
'hasRecommendedUMask' => $this->hasRecommendedUMask(),
]
);
}
Expand Down